Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per Volume Inode Accounting #35132

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Per Volume Inode Accounting #35132

merged 1 commit into from
Nov 6, 2016

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 19, 2016 •
edited

Collects volume inode stats using the same find command as cadvisor. The command is "find path -xdev -printf '.' | wc -c". The output is passed to the summary api, and will be consumed by the eviction manager.

This cannot be merged yet, as it depends on changes adding the InodesUsed field to the summary api, and the eviction manager consuming this. Expect tests to fail until this happens.
DEPENDS ON #35137

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 3649f6c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 3649f6c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 3649f6c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 3649f6c. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 3649f6c. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 3649f6c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 3649f6c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 3649f6c. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Oct 19, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 3649f6c. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@mtaufen mtaufen assigned dchen1107 and unassigned pmorie Oct 19, 2016
@dashpole
Copy link
Contributor Author

pkg/volume/metrics_du.go, line 76 at r1 (raw file):

}

// runDu executes the "find" command and writes the results to metrics.InodesUsed

s/runDu/runFind

Comments from Reviewable

@dashpole
Copy link
Contributor Author

dashpole commented Nov 1, 2016

@dchen1107 this should be ready to merge once you review it.

@dchen1107 dchen1107 added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Nov 3, 2016
@dchen1107 dchen1107 added this to the v1.5 milestone Nov 3, 2016
@dchen1107
Copy link
Member

LGTM. Can you add a node e2e test which has a pod with an empty volume and create some files and check /summary if properly reporting the number of inodes of such volume? You can send that test in a separate pr. Thanks!

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2016
@dashpole
Copy link
Contributor Author

dashpole commented Nov 3, 2016

The end to end test: #33955.
It makes one pod with an empty-dir volume, and fills that up with inodes to trigger eviction.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f650ddf into kubernetes:master Nov 6, 2016
luxas added a commit to luxas/kubernetes that referenced this pull request Nov 6, 2016
@luxas
Fix the crossbuild that kubernetes#35132 broke
190a513
k8s-github-robot pushed a commit that referenced this pull request Nov 7, 2016
Merge pull request #36313 from luxas/fix_crossbuild2
94bbe29 
Automatic merge from submit-queue

Fix the crossbuild that #35132 broke

@dashpole @dchen1107 @vishh 

A quick LGTM would be nice in order to not block any releases.
@dashpole dashpole deleted the per_volume_inode branch November 7, 2016 17:57
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
@jahkeup jahkeup mentioned this pull request Sep 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dashpole @k8s-ci-robot @dchen1107 @k8s-github-robot @pmorie @googlebot